-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Qt6 Multimedia Dependency Issue With ShaderTools #20565
Fixing Qt6 Multimedia Dependency Issue With ShaderTools #20565
Conversation
@ericLemanissier It may be useful to take a look at this PR. |
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
bcf3455
to
4ba6282
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
Conan v1 pipeline ❌Sorry, the build is only launched for Access Request users. You can request access writing in this issue. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by /~https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
closes conan-io#20565 fixes conan-io#20383 also, be a little more strict with options usage
Specify library name and version: qt/6.5.2
I've noticed that my statically built Qt6 on Windows failed when I set the
qtmultimedia
option.From a quick glance at the code, I noticed that the
default_options
are frozen inside theconfigure(...)
method, where the function that is supposed to be setting the module dependency options (likeqtmultimedia
should setqtshadertools
) runs. This option setting fails with the errorConanException: Incorrect attempt to modify option 'qtshadertools' from 'False' to 'True'
. This is documented in this issue.As a quick fix, we can remove the default value of
qtshadertools
so it does not get frozen, allowing the_enablemodule
calls in the recipe to succeed setting the dependencies from theqtmodules6.5.2.conf
file as expected.I also suspect that other module dependencies may be broken, as the freezing behaviour seems to be a breaking change from Conan 1.x as documented here. I haven't had time to build other optional Qt6 modules yet.