Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Qt6 Multimedia Dependency Issue With ShaderTools #20565

Closed

Conversation

matheusgomes28
Copy link
Contributor

Specify library name and version: qt/6.5.2

I've noticed that my statically built Qt6 on Windows failed when I set the qtmultimedia option.

From a quick glance at the code, I noticed that the default_options are frozen inside the configure(...) method, where the function that is supposed to be setting the module dependency options (like qtmultimedia should set qtshadertools) runs. This option setting fails with the error ConanException: Incorrect attempt to modify option 'qtshadertools' from 'False' to 'True'. This is documented in this issue.

As a quick fix, we can remove the default value of qtshadertools so it does not get frozen, allowing the _enablemodule calls in the recipe to succeed setting the dependencies from the qtmodules6.5.2.conf file as expected.

I also suspect that other module dependencies may be broken, as the freezing behaviour seems to be a breaking change from Conan 1.x as documented here. I haven't had time to build other optional Qt6 modules yet.


@CLAassistant
Copy link

CLAassistant commented Oct 14, 2023

CLA assistant check
All committers have signed the CLA.

@matheusgomes28
Copy link
Contributor Author

@ericLemanissier It may be useful to take a look at this PR.

@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'.

👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

ericLemanissier added a commit to ericLemanissier/conan-community-index that referenced this pull request Oct 16, 2023
ericLemanissier added a commit to ericLemanissier/conan-community-index that referenced this pull request Oct 16, 2023
closes conan-io#20565
fixes conan-io#20383

also, be a little more strict with options usage
conan-center-bot pushed a commit that referenced this pull request Oct 27, 2023
closes #20565
fixes #20383

also, be a little more strict with options usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants